Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Refactor/types #65

Merged
merged 3 commits into from
Sep 21, 2024
Merged

🔨 Refactor/types #65

merged 3 commits into from
Sep 21, 2024

Conversation

MEHRSHAD-MIRSHEKARY
Copy link
Collaborator

  • Added type aliases for various notification-related models and parameters:
    • Recipient: Optional user model representing a notification recipient.
    • Recipients: Union type for a single user, queryset, or list of users.
    • Groups: Union type for a single group, queryset, or list of groups.
    • OptConditions: Optional query conditions using Django's Q object.
    • Link: Optional string for notification links.
    • Actor: Represents a model that acts on behalf of the user.
    • Target: Optional model representing the target of the notification.
    • ActionObject: Optional model representing the action object related to the notification.
    • Data: Optional JSONField for additional data related to the notification.
    • Description: Optional string for a description of the notification.

Closes #64

@MEHRSHAD-MIRSHEKARY
✨🎨 feat(constants): Add queryset default type annotations
c893cc7 
- Added type aliases for various notification-related models and parameters:
  - Recipient: Optional user model representing a notification recipient.
  - Recipients: Union type for a single user, queryset, or list of users.
  - Groups: Union type for a single group, queryset, or list of groups.
  - OptConditions: Optional query conditions using Django's Q object.
  - Link: Optional string for notification links.
  - Actor: Represents a model that acts on behalf of the user.
  - Target: Optional model representing the target of the notification.
  - ActionObject: Optional model representing the action object related to the notification.
  - Data: Optional JSONField for additional data related to the notification.
  - Description: Optional string for a description of the notification.
@MEHRSHAD-MIRSHEKARY
⚡🔨🎨 refactor(queryset): Update type annotations to apply constant types
9e7f5bb 
Closes Lazarus-org#64
@MEHRSHAD-MIRSHEKARY
🎨⚡📚 refactor(docs): Update API docstring and fix typos
041aaf1
@MEHRSHAD-MIRSHEKARY MEHRSHAD-MIRSHEKARY added the enhancement New feature or request label Sep 21, 2024
ARYAN-NIKNEZHAD
ARYAN-NIKNEZHAD approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@ARYAN-NIKNEZHAD ARYAN-NIKNEZHAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👌

@ARYAN-NIKNEZHAD ARYAN-NIKNEZHAD merged commit d552ea1 into Lazarus-org:main Sep 21, 2024
4 checks passed
@MEHRSHAD-MIRSHEKARY MEHRSHAD-MIRSHEKARY deleted the refactor/types branch September 26, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARYAN-NIKNEZHAD ARYAN-NIKNEZHAD ARYAN-NIKNEZHAD approved these changes

Assignees

@MEHRSHAD-MIRSHEKARY MEHRSHAD-MIRSHEKARY

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing types constant file for type annotations
2 participants
@MEHRSHAD-MIRSHEKARY @ARYAN-NIKNEZHAD